fix(Sema): fix 0-bit fields inside extern or packed structs #23341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to add a behavior test if possible. |
|
Pretty sure zero-bit stores aren't meant to actually reach this code, since they're valid on any pointer and are always nops so shouldn't go through the actual store machinery. I'll take a closer look shortly. |
Related #23640 |
|
Superseded by #23712. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
externandpackedstructs with 0-bit fields, for which stores in them weren't properly handled.First time touching the compiler 🤞🏼
I'm all ears for nits and suggestions.
Resolves #23307