Fix various cases of incorrect types for color arguments. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not pointers, but value types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type for the argument
colorfor many of the debug rendering functions appears to be wrong. It seems like it's actually passed by value, not by pointer. This was causing a segfault for me.It's weird because e.g.
drawGeometry()has the color passed by value, but I guess the rest didn't get updated at the same time.In the jolt documentation they are also passed by value: https://jrouwe.github.io/JoltPhysics/class_debug_renderer.html#acea9470f13a1d50b677e2aaaeb9eeaed