Prevent naming collisions with native qcodes attributes. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adapts the node tree generation to append a tailing underscore to parameter names that colided with native qcodes attribute on the Instrument/Node classes. Since QCoDes simply ignores attempts to add colliding names and just raises a warning, this change is not breaking. Currently only the name `log` from `/zi/debug/log` is colliding but this fix also works for future collisions.
|
Thanks @tobiasah I was meaning to submit a bug for this after I made the change to qcodes. This seems like a good fix |
markheik
approved these changes
Aug 15, 2024
|
@tobiasah It would be great to see this merged and in a release along with the python 3.7 drop pr if possible |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the node tree generation to append a tailing underscore to parameter names that colided with native qcodes attribute on the Instrument/Node classes. Since QCoDes simply ignores attempts to add colliding names and just raises a warning, this change is not breaking.
Currently only the name
logfrom/zi/debug/logis colliding but this fix also works for future collisions.