Fix invalid session regeneration on wrong session ID #166
Conversation
| @@ -426,7 +426,7 @@ public static function start($options = false) | |||
| // Generate a valid, temporary replacement | |||
| self::setId(md5(self::getId())); | |||
| // Force a regenerate after session is started | |||
| self::$_regenerateIdState = -1; | |||
| self::regenerateId(); | |||
There was a problem hiding this comment.
we have to explicitly call this method because in this situation the function will return at line 438 because "already started".
There was a problem hiding this comment.
the ident seems off: mixing tabs and spaces?
stick to existing formatting.
also, never send pull request from master branch. all commits added to the branch end up in the pull request which might not be wanted. also rebase force push might be difficult (rejected)
There was a problem hiding this comment.
🤔 I have editorconfig up and running, though 🤷
I meant to checkout a branch, my bad (again).
There was a problem hiding this comment.
you didn't need to close it yet, if it's not conflicting yet. i.e you do not yet want other changes to your master.
and if you did create a replacement pr, mention it in old pr too to keep things transparent
There was a problem hiding this comment.
It closed automatically as soon as I rolled back my master branch to follow yours.
fredericgboutin-yapla
force-pushed
the
master
branch
from
acc0c09
to
29758cd
Compare
Fix for #165