Skip to content

Adds PHP 8.4 compatibility #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adds PHP 8.4 compatibility #16

wants to merge 1 commit into from

Conversation

marcing
Copy link
Collaborator

@marcing marcing commented Apr 10, 2025

  • Adds necessary changes for achieving PHP 8.4 compatibility
  • Switches PEAR to github, because PEAR repository was removed and no longer works with composer v2
  • Removes PHP 5.3 -> 7.0 compatibility due to lack of syntax that would work for both PHP <= 7.0 and 8.4+
  • Removes E_STRICT, which is triggers deprecated error

Edit: This pull request will be split into specific ones.

@marcing marcing requested review from partikus and falkenhawk April 10, 2025 17:02
…ted", removes E_STRICT, sets PHP 7.1 as minimum version
@glensc
Copy link

glensc commented Apr 10, 2025

In my opinion, this pr should be rejected:

  1. No description
  2. The actual diff does more than described in the title
  3. alert! removes things, not backward compatible

It would be wasting maintainers' time trying to reverse engineer the changes description from the diffs

Ideally, each change should be submitted as a separate pr, and pr describes the changes.

Note: I'm not a maintainer of this project (but I am elsewhere).

@marcing
Copy link
Collaborator Author

marcing commented Apr 11, 2025

@glensc

  1. Updated the description
  2. All the changes are necessary to make it work with PHP 8.4, it does nothing more (please see new description)
  3. it removes E_STRICT, because it got removed from PHP

It's part of pull request for zf1 and without it the tests fail:
zf1s/zf1#198

Cheers

@marcing marcing marked this pull request as draft April 11, 2025 09:31
@marcing marcing closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants