Generate padding fields in VolkDeviceTable to preserve ABI #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid issues with ABI compatibility of volk built with different sets of defines, we now generate padding fields for each extension block with the same number of function pointers. This should make sure that the offset of every pointer for any given volk version remains stable, simplifying binary builds.
Sequential indices are problematic for future updates, as updates in the middle of the structure are common, and they will result in larger and less readable diffs. Instead we can use the CRC32 of the padding contents to name the field.
charles-lunarg
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues with ABI compatibility of volk built with different sets
of defines, we now generate padding fields for each extension block with
the same number of function pointers. This should make sure that the
offset of every pointer for any given volk version remains stable,
simplifying binary builds.
Fixes #230