throw() -> noexcept

[r-barnes]

throw() was deprecated in C++11 and removed in C++17. noexcept is the appropriate fix.

[zeux]

Only deprecated in 17 and removed in 20 according to https://en.cppreference.com/w/cpp/language/noexcept_spec. pugixml doesn’t require C++11 so this will need to be guarded appropriately.

[r-barnes]

@zeux - ironically the same site shows C++11/C++17 here, but what you've found matches my experience: https://en.cppreference.com/w/cpp/language/except_spec

I've used the gated form.

[zeux]

ironically the same site shows C++11/C++17 here

That’s referring to a non-empty throw specification which had a different deprecation schedule.

[zeux]

PUGIXML_NOEXCEPT should be defined as throw() for builds to pass I believe.