This repository is an implementation of very simple storage based on Python dictionary.
The storage supports four operations:
- add: adds
<key,value>
into storage, if thekey
is present raise anException
- get: returns a
value
for a givenkey
orNone
if no suchkey
, - remove: removes
<key,value>
pair based onkey
, - set: sets a new
value
for a givenkey
if thekey
is present
get is already implemented
Your task is to finish this implementation collaboratively using git
. Also it is needed to provide a unittest for each method implemented in Storage
class.
- You are divided into several teams. One member of each team should
fork
this repository. Add your teammates ascontributors
- Team members decide on which functionality they will implement (i.e. method under
storage.py
and a corresponding test undertests.py
) - After that, members clone forked repository, create a
branch
with a namefeature/add
(orremove
, orset
), implement this functionality under that branch - When the functionality is implemented and tested locally push it to the
remote
and openpull request
to themaster
branch of thefork
from the first item - Other teammates not involved in realization of this very feature are asked to review
pull request
and give a positive feedback under the comments if it's OK. After that, owner ofmaster
branch merges all these features intomaster
As a result there should be completed functionality that evidently built in parallel.
Q1: If I am the owner of the master
branch should I create feature
branch or it is possible for me to push it directly to the master
A1: Ownership of the master
branch doesn't provide you rights to push there directly if you're working on a project with a team. Each feature should be accepted with other members of the project. There's also an option in GitHub repo settings that won't give a possibility to push in origin/master
directly
Q2: How to make the pull request
A2: Please follow https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request