-
Notifications
You must be signed in to change notification settings - Fork 68
docs: v15 mainnet deployment info #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe PR updates multiple broadcast run artifacts (various Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
data/checksum/mainnet.jsonis excluded by!data/**
📒 Files selected for processing (7)
broadcast/DeployGatewayEVMImplementation.s.sol/1/run-latest.json(2 hunks)broadcast/DeployGatewayEVMImplementation.s.sol/137/run-latest.json(2 hunks)broadcast/DeployGatewayEVMImplementation.s.sol/42161/run-latest.json(1 hunks)broadcast/DeployGatewayEVMImplementation.s.sol/43114/run-latest.json(1 hunks)broadcast/DeployGatewayEVMImplementation.s.sol/56/run-latest.json(2 hunks)broadcast/DeployGatewayEVMImplementation.s.sol/8453/run-latest.json(2 hunks)scripts/deploy/deterministic/DeployGatewayEVMImplementation.s.sol(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
scripts/**
⚙️ CodeRabbit configuration file
Review the Hardhat scripts for best practices.
Files:
scripts/deploy/deterministic/DeployGatewayEVMImplementation.s.sol
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: test
- GitHub Check: generate
- GitHub Check: slither
🔇 Additional comments (8)
broadcast/DeployGatewayEVMImplementation.s.sol/42161/run-latest.json (1)
1-64: Deployment artifact is valid and consistent. ✓The JSON artifact shows a successful CREATE2 deployment of GatewayEVM on Arbitrum (chain 42161) with:
- Transaction status:
0x1(success)- Consistent hashing across transaction and receipt fields
- Coherent block metadata (blockNumber
0x17da8937, matching blockHash)- Reasonable gas consumption (~3.7M)
- Timestamp aligned with PR date (Dec 10, 2025)
All internal cross-references (transaction hash, block hash, block number) are consistent. No data corruption detected in the artifact.
To confirm the deployment aligns with the PR objectives (v15 mainnet deployment with updated CREATE2 salt), please verify:
- That this salt change (
keccak256("GatewayEVM_V15")) was properly applied in the deployment script- That the contract address
0x1fff55ccf855212f6b5530c468b44f9a5246572ematches the expected output for the new saltbroadcast/DeployGatewayEVMImplementation.s.sol/1/run-latest.json (2)
1-62: The file location and content are correct for mainnet. The git commit message explicitly states "v15 mainnet deployment info," and testnet artifacts are properly stored in their respective chain-ID directories (e.g.,broadcast/DeployGatewayEVMImplementation.s.sol/11155111/for Sepolia,421614/for Arbitrum Sepolia). This is standard Foundry deployment structure—no mismatch exists.
4-4: Multi-chain deployment artifacts are properly consistent.The implementation bytecode is identical across production chains (1, 137, 42161, 43114, 56, 8453), all sharing the same deterministic CREATE2 address
0x1fff55ccf855212f6b5530c468b44f9a5246572eand commit hashe2108b4. Testnet chains correctly use a separate address and commit. While timestamps vary per deployment (expected, as each chain deployed at different times), the commit hashes and contract addresses are properly aligned within their respective deployment tiers, confirming the CREATE2 determinism is functioning correctly.broadcast/DeployGatewayEVMImplementation.s.sol/43114/run-latest.json (1)
1-61: LGTM! Deployment artifact correctly reflects the new CREATE2 address.This artifact is generated by Forge and correctly captures the deployment transaction for chain 43114 (Avalanche C-Chain) with the new implementation address
0x1fff55ccf855212f6b5530c468b44f9a5246572e.broadcast/DeployGatewayEVMImplementation.s.sol/137/run-latest.json (1)
1-77: LGTM! Deployment artifact correctly reflects the new CREATE2 address.This artifact is generated by Forge and correctly captures the deployment transaction for chain 137 (Polygon) with the new implementation address
0x1fff55ccf855212f6b5530c468b44f9a5246572e, which matches the address on other chains as expected for deterministic CREATE2 deployments.broadcast/DeployGatewayEVMImplementation.s.sol/8453/run-latest.json (2)
65-68: Base deployment is consistent with all production chains.Verified that commit e2108b4 and contract address 0x1fff55ccf855212f6b5530c468b44f9a5246572e are consistently applied across all production chains (Ethereum, Polygon, Arbitrum, Avalanche, BSC, and Base). Testnet deployments correctly remain at an earlier commit (98b6687).
1-68: Verify JSON artifact syntax and CREATE2 address derivation for v15 update.The deployment artifact structure appears sound with consistent cross-referenced fields across transaction and receipt sections. Status shows successful deployment (
0x1). However, programmatic validation of the JSON file could not be completed, and deterministic validation of the contract address0x1fff55ccf855212f6b5530c468b44f9a5246572eagainst the v15 salt requires additional verification against the deployment script's salt constant (keccak256("GatewayEVM_V15")).broadcast/DeployGatewayEVMImplementation.s.sol/56/run-latest.json (1)
1-61: No issues found. This broadcast artifact is correctly auto-generated and tracked.This file documents a successful CREATE2 deployment of GatewayEVM on BSC (chain 56) with the salt
keccak256("GatewayEVM_V15"), consistent with the deployment script atscripts/deploy/deterministic/DeployGatewayEVMImplementation.s.sol. Broadcast artifacts for production chains are intentionally committed to version control in this repository to document reproducible deployments. The transaction, receipt, and block data are internally consistent, and the deployment record is properly generated as part of the v15 mainnet deployment process.
scripts/deploy/deterministic/DeployGatewayEVMImplementation.s.sol
Outdated
Show resolved
Hide resolved
Sherlock AI |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.