[Content] Prevent new draft from being created on content item creation #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnar-bin
added
bug
agalin920
requested changes
Jun 24, 2024
| @@ -101,10 +102,10 @@ export const ItemCreate = () => { | |||
|
|
|||
| // if item doesn't exist, generate a new one | |||
| useEffect(() => { | |||
| if (isEmpty(item)) { | |||
| if (isEmpty(item) && !skipNewItemGeneration) { | |||
There was a problem hiding this comment.
This solution is kinda hacky. Can we not prevent this useEffect from firing in a traditional way? Im assuming the save is causing item to mutate but cant we navigate away (unmount) before doing so?
There was a problem hiding this comment.
Updated. This will prevent the creation of a new draft while the new item is being saved
finnar-bin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2726