Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert spaces to dashes when searching #1506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert spaces to dashes when searching #1506

wants to merge 1 commit into from

Conversation

agalin920
Copy link
Contributor

No description provided.

@agalin920 agalin920 linked an issue Nov 7, 2022 that may be closed by this pull request
Media App: Handling Spaces in Search #1474
Open
@shrunyan
Copy link
Contributor

shrunyan commented Nov 8, 2022 •
edited
Loading

I have concerns with this change. There are inconsistency with the experience. Currently the UI allows editing of a filename and including spaces within that name but it is not the true state of the file as once you save it and the new file URL is generated it replaces the spaces with hyphens.

Essentially there are 2 concerns I have.

  1. an unclear and inconsistent experience on how this should all behave
  2. a judgement and forcing users out of using spaces. I don't think we should do this.

@agalin920
Copy link
Contributor Author

@zcolah Any input on the concerns above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrunyan shrunyan Awaiting requested review from shrunyan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media App: Handling Spaces in Search
2 participants
@agalin920 @shrunyan