Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some banner/notes have a differently illuminated square in the center #20

Open
XC3N opened this issue Aug 24, 2022 · 2 comments
Open

Some banner/notes have a differently illuminated square in the center #20

XC3N opened this issue Aug 24, 2022 · 2 comments

Comments

@XC3N
Copy link

XC3N commented Aug 24, 2022

I am attaching a few screenshots to show what I mean, some banner and notes textures have a square in the middle that has a different lighting value
morobug2-5
morobug2-2
morobug2-6
.

@zesterer
Copy link
Owner

zesterer commented Aug 24, 2022

This is, unfortunately, another case of #9.

The shaders see that the edges of the banner have transparency and incorrectly identify them as foliage. As a result, it applies the foliage shader which has a slightly different lighting model (and adds, for example, a cheap approximation of sub-surface scattering, as would be appropriate for leaves). As a result, the outside of the banner reflects light in a slightly different manner to the inside of the banner.

Short-term, a "solution" might be to avoid treating translucent polygons as foliage if they're indoors, given that the vast majority of banners appear indoors (although even detecting this is a fallible process :( ).

Long-term, I'd really like to see OpenMW gain some system for differentiating between materials so that shaders can act accordingly.

@XC3N
Copy link
Author

XC3N commented Aug 24, 2022

haha I was half expecting this. Again, this is not too distracting but now it's documented for others! ;)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants