Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Night-Eye spell illuminates only water surface #14

Open
pante11 opened this issue Jul 5, 2022 · 6 comments
Open

Night-Eye spell illuminates only water surface #14

pante11 opened this issue Jul 5, 2022 · 6 comments

Comments

@pante11
Copy link

pante11 commented Jul 5, 2022

Night-Eye spell somehow illuminates exclusively water surface while all of my surroundings remains dark. It happens only while shaders are installed.

@zesterer
Copy link
Owner

zesterer commented Jul 5, 2022

Do you have a screenshot of this?

@pante11
Copy link
Author

pante11 commented Jul 5, 2022

Before and after:

screenshot036
screenshot037

It's not very visible on screenshots, but you should see small change in the reflection.

And the next thing that I discovered just now is that it works this way only in the dusk when everything is dimmed but not entirely dark. Casting night-eye in complete darkness or during bright day doesn't change anything at all, not even the reflection.

@zesterer
Copy link
Owner

zesterer commented Jul 5, 2022

Does the night-eye spell create a subtle point light around the player? If so, this would explain things: I overhauled the lighting model, which might result in lights being more visibly reflected from the surface of water.

@pante11
Copy link
Author

pante11 commented Jul 5, 2022

I don't know how does this spell technically work, but I'm not exactly convinced that's the issue. I created 100 points version of this spell (previous one was 30 points) and what's changed is that now water is even brighter than earlier - but everything else still seems to be unaffected.
screenshot038
screenshot039

@pante11
Copy link
Author

pante11 commented Jul 5, 2022

And this is how the same spell effect works without your shaders:
screenshot041
screenshot042

@zesterer
Copy link
Owner

zesterer commented Jul 5, 2022

Hmm, so it seems like the spell does something hacky like adding ambient light to everything. Thanks for the information, I'll look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants