Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages-action#131: make logs more verbose for errors in octo #100

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

Yegorov
Copy link
Contributor

@Yegorov Yegorov commented Sep 20, 2024

For find bug in zerocracy/pages-action#131

@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 20, 2024

@Suban05 can you review, please

Copy link
Contributor

@Suban05 Suban05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yegorov looks very good! I have some questions

lib/fbe/middleware/logging_formatter.rb Show resolved Hide resolved
lib/fbe/middleware/logging_formatter.rb Show resolved Hide resolved
lib/fbe/middleware/logging_formatter.rb Outdated Show resolved Hide resolved
lib/fbe/middleware/logging_formatter.rb Outdated Show resolved Hide resolved
test/fbe/middleware/test_logging_formatter.rb Show resolved Hide resolved
lib/fbe/middleware/logging_formatter.rb Show resolved Hide resolved
@Yegorov
Copy link
Contributor Author

Yegorov commented Sep 22, 2024

@yegor256 please check

@yegor256 yegor256 merged commit 6ec065c into zerocracy:master Sep 23, 2024
9 checks passed
@yegor256
Copy link
Member

@Yegorov thanks!

@0crat
Copy link

0crat commented Sep 23, 2024

@Suban05 Thanks for the review! 🌟 You've earned +4 points, which is the base reward for contributing. While it's not the maximum possible (24 points), it's still a solid contribution. Your running balance is now +111. Keep up the good work, and remember that more detailed reviews with more comments can lead to higher rewards!

@0crat
Copy link

0crat commented Sep 23, 2024

@Yegorov 🎉 Fantastic work! Your contribution has earned you +13 points: +4 base and +8 for your impressive 175 hits-of-code. Keep up the great momentum! Your total balance now stands at +149. We're excited to see what you'll achieve next!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants