Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Briancheung1 apartment #96

Merged
merged 6 commits into from
Oct 6, 2024

Conversation

BrianCheung1
Copy link
Contributor

Added basic apartment map to apartment_door_1

I was unsure how to create an exit location for the player as there is no "enter_apartment" spot yet so I just used the enter_arcade as that was the closest

I figured out the basic tile sheet for walls/floor. I used Kenny's RPG urban pack

could you guys provide the link to the other basic stuff like TV, plants, chairs, etc.

Copy link

🙏 Thanks for your pull request @BrianCheung1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
96 603 2
📑 Files Changed: Repo Stars: 🔱 Total Forks:
12 24 57

Copy link

🙏 Thanks for your pull request @BrianCheung1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
96 603 2
📑 Files Changed: Repo Stars: 🔱 Total Forks:
12 24 57

@BrianCheung1 BrianCheung1 force-pushed the briancheung1-apartment branch from 894152d to 3f17fca Compare October 6, 2024 06:09
Copy link

🙏 Thanks for your pull request @BrianCheung1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
96 416 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
8 24 57

@BrianCheung1
Copy link
Contributor Author

commited another branches changes by accident
i rebased those commits and then
removed them with a forced push

Copy link

🙏 Thanks for your pull request @BrianCheung1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
96 416 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
8 26 58

Copy link

🙏 Thanks for your pull request @BrianCheung1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
96 855 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
13 26 58

Copy link

🙏 Thanks for your pull request @BrianCheung1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
96 855 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
13 26 58

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@r4pt0s r4pt0s merged commit 4ff2872 into zero-to-mastery:main Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants