-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interaction for computer in room 1 + fix formatting in other files to pass CI checks #63
Conversation
🙏 Thanks for your pull request @AryanK1511, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
@r4pt0s, The checks fail due to some files related to the |
🙏 Thanks for your pull request @AryanK1511, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
@AryanK1511 that would be great 🙏🏻 |
🙏 Thanks for your pull request @AryanK1511, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @AryanK1511, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
@r4pt0s, Seems like everything works perfectly now! We are all set to merge 🫡 |
Fixes
In response to @r4pt0s's suggestion, I have used the
displayDialogueWithCharacter
function to display HTML content to the user whenever the sprite collides with the computer object. This HTML contains a link to the ZTM Careers Page that opens the website in a new tab when clicked.Here's an image of what this looks like:
Here’s the relevant code for reference:
I have attached a video to showcase the functionality and appearance of the dialogue box in action:
Screen.Recording.2024-10-03.at.3.11.33.AM.mov
The code has been formatted using Prettier, and all linting checks have been successfully passed locally.
Please review the changes, and let me know if you would like any modifications or further enhancements.