Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Allows character to enter back into the academy thru the right door #51

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

gdsouza1992
Copy link
Contributor

@gdsouza1992 gdsouza1992 commented Oct 2, 2024

issue #26
image

Adds ability to enter back into academy.

The exit from the academy puts the character infront of the left door but slightly lower to avoid triggering the collision with the door automatically.

Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 8 2
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 10 26

1 similar comment
Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 8 2
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 10 26

@gdsouza1992 gdsouza1992 changed the title Allows character to enter back into the academy thru the right door FEAT: Allows character to enter back into the academy thru the right door Oct 2, 2024
Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 8 2
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 10 26

Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 8 2
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 10 31

@r4pt0s
Copy link
Collaborator

r4pt0s commented Oct 2, 2024

@gdsouza1992 : What do think about the idea, if we move the spawnpoint y coordinate of the player a bit more down instead of "closing the door" 🤔?

This would fix the problem and would also give us the chance to leave the door open.

I think of a future feature where NPCs are going into the academy.

@gdsouza1992
Copy link
Contributor Author

gdsouza1992 commented Oct 2, 2024 via email

Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 6 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 13 35

Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 7 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 13 35

1 similar comment
Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 7 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 13 35

@gdsouza1992
Copy link
Contributor Author

@gdsouza1992 : What do think about the idea, if we move the spawnpoint y coordinate of the player a bit more down instead of "closing the door" 🤔?

This would fix the problem and would also give us the chance to leave the door open.

I think of a future feature where NPCs are going into the academy.

New spawn point updated and screenshot attached to show the position.

Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 7 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 13 35

Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 7 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 18 36

Copy link

🙏 Thanks for your pull request @gdsouza1992, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
51 7 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 18 41

@r4pt0s r4pt0s merged commit 512ce3f into zero-to-mastery:main Oct 3, 2024
1 check passed
@r4pt0s r4pt0s added hacktoberfest Hacktoberfest label for 2024 hacktoberfest-accepted labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest label for 2024 hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants