first interaction with arcade employee #47
Conversation
|
🙏 Thanks for your pull request @abdulrahimsulthan, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🥳 Congratulations 🎉Congrats on making your first Pull Request in the Zero To Mastery Organization! ZTM Profile BadgeIf you'd like the ZTM Badge to show up on your profile, you will need to follow this guide! |
|
#30 linked to this issue |
|
🙏 Thanks for your pull request @abdulrahimsulthan, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @abdulrahimsulthan, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @abdulrahimsulthan, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @abdulrahimsulthan, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
I didnt touch this file it give some linting issues src/interactions/map_start/jokeTeller.interaction.js |
|
@abdulrahimsulthan I know. Can you just update the PR with the latest version of main? |
| export const firstInteractionWithUncleBob = (player, k, map) => { | ||
| player.onCollide('uncle_bob', () => { | ||
| player.isInDialog = true; | ||
| displayDialogueWithCharacter( |
There was a problem hiding this comment.
Could you please remove the displayDialogueWithCharacter function call here?
We have now a event system started for interactions. To get an idea what you have to add, have a look at this interaction
it is basically just wrapping it into a object.
Also, add uncleBobVisitOne to the player state object so that we can persist it into local storage
displayDialogue({
k,
player,
characterName: 'Uncle Bob',
text: firstConversationArcade,
onDisplayEnd: () => {
player.isInDialog = false;
player.state.uncleBobVisitOne = true;
},
});
|
please also checkout npcInteractionHandler function in handler.interactions.js |
|
@abdulrahimsulthan are you still working on it? |
|
Closed due to inactivity. @abdulrahimsulthan if still want to make these changes, please open a new pull request 🙏🏻 |
First interaction with arcade employee done, Need a time to get some fun idea with games playing.