Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard controls #42

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

KevinBatdorf
Copy link
Contributor

This PR adds keyboard support. My first time using kaplay.js so could be that I did something not very idiomatic.

Closes #28

CleanShot.2024-10-02.at.00.05.14.mp4

Copy link

🙏 Thanks for your pull request @KevinBatdorf, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
42 75 9
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 7 19

Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me. Good job 👏🏻

Copy link

🙏 Thanks for your pull request @KevinBatdorf, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
42 74 9
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 8 20

@r4pt0s
Copy link
Collaborator

r4pt0s commented Oct 1, 2024

@KevinBatdorf could you please update the PR with the latest changes of the main branch?

Copy link

🙏 Thanks for your pull request @KevinBatdorf, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
42 74 9
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 8 22

Copy link

🙏 Thanks for your pull request @KevinBatdorf, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
42 74 9
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 8 22

@KevinBatdorf
Copy link
Contributor Author

Merged

@r4pt0s r4pt0s merged commit f17d169 into zero-to-mastery:main Oct 1, 2024
1 check passed
@KevinBatdorf KevinBatdorf deleted the add-keyboard-controls branch October 1, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keyboard controls for controlling the character
2 participants