Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change player state to proxy object #183

Merged
merged 6 commits into from
Oct 27, 2024

Conversation

HASH-0021
Copy link
Contributor

Changes:

  • One of the previous PRs (Bug fix for bootstrap #176) fixed an issue (exiting while in dialog box caused player not able to move). This fix brought a breaking change as the player state now is modified to a normal object instead of proxy object. I made the change to instead update the proxy object as this object might have dependencies (atleast my previous features). If this is how the player state(as normal object) should be, then changes need to be done wherever necessary (let me know). With this fix, coins can be properly used for purchasing.
  • enterMapCityLeft interaction incorrectly points out that Bruno is on left whereas he is at another entrance. Fixed this and other small typos.
  • Jessie's interaction in arcade map seemed like she is newly introducing herself with every statement. Changed this to only show one of the introductory statements. Added few more lines regarding earning coins while playing games to some statements.
  • When an arcade game is exited using exit button through mouse click, the mouse click stays over even after the scene is changed. So, unless the mouse is clicked again, the player keeps following the cursor. Changed event of exit button in lose.js file from onClick to onMouseRelease.

Copy link

🙏 Thanks for your pull request @HASH-0021, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
183 31 13
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 27 90

Copy link

🙏 Thanks for your pull request @HASH-0021, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
183 31 13
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 27 90

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

Copy link

🙏 Thanks for your pull request @HASH-0021, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
183 31 13
📑 Files Changed: Repo Stars: 🔱 Total Forks:
6 27 92

@r4pt0s r4pt0s merged commit 63bfc00 into zero-to-mastery:main Oct 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants