Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Living room Interaction #178

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Conversation

avneets0419
Copy link
Contributor

If you like the code please merge it and please add it to hacktober fest 2024

Copy link

🙏 Thanks for your pull request @avneets0419, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
178 40 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 27 89

Copy link

🙏 Thanks for your pull request @avneets0419, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
178 40 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 27 89

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.
Just one step missing here to get it merged.
Add your interaction to the array of the index.js file which you can find in the same directory where the new files is.
You can find find more information here

Copy link

⚠️ MERGE CONFLICT DETECTED!

@avneets0419 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
Copy link

⚠️ MERGE CONFLICT DETECTED!

@avneets0419 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

Copy link

🙏 Thanks for your pull request @avneets0419, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
178 42 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 27 89

1 similar comment
Copy link

🙏 Thanks for your pull request @avneets0419, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
178 42 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 27 89

@avneets0419 avneets0419 requested a review from r4pt0s October 26, 2024 08:20
Copy link

🙏 Thanks for your pull request @avneets0419, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
178 42 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
2 27 89

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@r4pt0s r4pt0s merged commit 62a9038 into zero-to-mastery:main Oct 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants