Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map campus interactions #175

Conversation

nishchalgv1
Copy link
Contributor

Added interactions to map_campus_house_1

issue: #130

Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
175 19 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
19 26 87

Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
175 19 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
19 26 87

@nishchalgv1 nishchalgv1 marked this pull request as ready for review October 23, 2024 19:47
Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
175 19 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
19 26 87

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishchalgv1 make sure you checkout always from the main branch. In this case, you checked out this new branch from your previous pull request branch.

Also, adding the interaction is not 100% ready in your PR.
You have to import your interaction into this file and add it to the interactions array.

Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
175 21 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
20 26 87

@nishchalgv1 nishchalgv1 requested a review from r4pt0s October 25, 2024 08:38
Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
175 21 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
20 26 87

@nishchalgv1
Copy link
Contributor Author

@nishchalgv1 make sure you checkout always from the main branch. In this case, you checked out this new branch from your previous pull request branch.

Also, adding the interaction is not 100% ready in your PR. You have to import your interaction into this file and add it to the interactions array.

I have incorporated the changes in the new branch feature/map_campus-interactions and pushed it. Now again how do I inculcate it with the PR

Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
175 21 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
20 26 88

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishchalgv1 can you reset the branch commit history to only include the latest changes of the main branch?
Your current PR branch has still the changes of the moved sound files.
You can also close this PR, created a new branch from the main branch and make another PR.
Or you move the sound files back where they were before.

@nishchalgv1 nishchalgv1 deleted the feature/map-campus-interactions branch October 26, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants