-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map campus interactions #175
map campus interactions #175
Conversation
🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nishchalgv1 make sure you checkout always from the main branch. In this case, you checked out this new branch from your previous pull request branch.
Also, adding the interaction is not 100% ready in your PR.
You have to import your interaction into this file and add it to the interactions array.
🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
I have incorporated the changes in the new branch feature/map_campus-interactions and pushed it. Now again how do I inculcate it with the PR |
🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nishchalgv1 can you reset the branch commit history to only include the latest changes of the main branch?
Your current PR branch has still the changes of the moved sound files.
You can also close this PR, created a new branch from the main branch and make another PR.
Or you move the sound files back where they were before.
Added interactions to map_campus_house_1
issue: #130