Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sounds to public #174

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Conversation

nishchalgv1
Copy link
Contributor

Created music/sounds to public directory

issue: #23

Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
174 0 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
18 26 87

Copy link

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
174 0 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
18 26 87

@nishchalgv1 nishchalgv1 marked this pull request as ready for review October 23, 2024 19:49
Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
174 0 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
18 26 87

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishchalgv1 it appears like you just moved the files into another directory.
Is this the case or is here a commit missing in your PR?

@nishchalgv1
Copy link
Contributor Author

@nishchalgv1 it appears like you just moved the files into another directory. Is this the case or is here a commit missing in your PR?
Yes moved the files into another directory as that's what I understood from the issue. No commit missing. If that's not being asked in the issue, could you please elaborate more about it?

@r4pt0s
Copy link
Collaborator

r4pt0s commented Oct 25, 2024

@nishchalgv1 sure.
This issue basically means creating new music tracks or sounds like car sounds or ambient sounds which we can then add to game.

Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
174 0 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 26 87

@nishchalgv1 nishchalgv1 requested a review from r4pt0s October 25, 2024 09:29
Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
174 0 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 26 87

Copy link

🙏 Thanks for your pull request @nishchalgv1, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
174 0 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 26 88

Copy link
Collaborator

@r4pt0s r4pt0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@r4pt0s r4pt0s merged commit b164bd6 into zero-to-mastery:main Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants