Added fishing minigame; Still bugs to fix #137
Conversation
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
Through the code changes I realized that all I really should have done was pass in a type of fishing scene then create the string scene so that the player could go back to the map they were on. |
|
@fullspeccoder that is what I meant on Discord. I tried to reduce the boilerplate code for scene addition. Hopefully it will help you to add your part more easily |
|
1 similar comment
|
…nto fullspeccoder
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
1 similar comment
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
I finally added the minigame! In a similar style to what you've refactored it to @r4pt0s, I have also fixed the scaling but I see that it was also fixed in another PR as well. Fixing the scaling helped with an overall issue I was having with the game. I tested escaping out of the game and it worked okay, the game works as intended, and overall seems to work okay. Let me know if there's any changes! |
|
Hi @fullspeccoder, I looked and tested it. On desktop everything looks and works as expected. Also, could you please merge the current main branch into your PR 🙏🏻 |
…nto fullspeccoder
…nto fullspeccoder
…nto fullspeccoder
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
Hello again! I have finally figured out a way to make the game look good on Mobile, as the screen was scrunched up at the top. Hopefully this is the absolute winner! Let me know if you need any more changes. @r4pt0s |
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
…nto fullspeccoder
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
🙏 Thanks for your pull request @fullspeccoder, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Fishing Minigame
Had to work through some major changes due to major refactor, but managed to figure it out at least for now. I implemented the fishing minigame for the project - but it doesn't work on mobile just yet. I was thinking of maybe implementing that version where the user stays in a spot and has to tap to get a fish.
Implementation
A game that allows you to cast a hook and will catch fish on the way up. In this version, you can move side to side (albeit slowly because that makes it more challenging). The fishes spawn in random places between boundaries with random sprites used from the fish.png image from the sprites folder. I used a strategy of loading assets before the game starts, configuring the assets to be used correctly, then allow the user to play the game.
Things To Improve
Upon successful catches once you leave the minigame, you should be able to keep the fish you caught. I'm not sure what this could look like; whether that means you can keep the specific names of the fish, or keeping the weights. There are so many possibilities!
Will work out details on getting state to work versus the triggerFishingAnimations and triggerNormalAnimations functions.
Hopefully the structure for the minigame won't affect the rest of the code in the project, I tried to modularize it as much as possible away from the rest of the code.