Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding my art to the project #2919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Steveo1975
Copy link

@Steveo1975 Steveo1975 commented Feb 21, 2025

Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.

While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!

What I did

Optional: Edit this to tell us what you did!

Pull request checklist

  • This pull request uses HTML and CSS only and provides a meta.json file.
  • All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
  • Your pull request contains index.html and styles.css.
    • Your html file is named exactly: index.html
    • Your css file is named exactly: styles.css
  • Your pull request your meta.json with:
    • githubHandle: being your unique github user name,
    • artName : name of your animation
  • Your submission includes at least one animation.
  • Your pull request does not modify any other files in the repository.

Not normally needed

  • Check this if you would like to discuss an improvement besides adding animations

Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section

What to expect

  • If your pull request meets the checklist requirements it will be approved and merged by a maintainer
  • If your pull request needs some changes. A maintainer will leave a comment requesting changes
  • If your pull request significantly violates the criteria in the checklist it will be closed with feedback.

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

10 similar comments
Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Copy link
Contributor

@LaurelineP LaurelineP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alohaaaa @Steveo1975
Thanks for your contribution 🙌
Please address the feedback before we could merge your contribution. :)
The PR might be closed at some point if there are no updates on the feedbacks but you will always be welcome to contribute if it was closed.
Happy coding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unecessary icon

Please remove the icon as this will be generated once your PR is merged

<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Bangers&display=swap" rel="stylesheet">
<link rel="stylesheet" type="text/css" href="style.css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect css file sheet ref to anticipate

  • the file should be named as styles.css and not style.css

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect css file

  • the file should be named as styles.css and not style.css

Copy link

🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2919 142 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 361 3629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants