-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding my art to the project #2919
base: master
Are you sure you want to change the base?
Conversation
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
10 similar comments
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alohaaaa @Steveo1975
Thanks for your contribution 🙌
Please address the feedback before we could merge your contribution. :)
The PR might be closed at some point if there are no updates on the feedbacks but you will always be welcome to contribute if it was closed.
Happy coding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unecessary icon
Please remove the icon as this will be generated once your PR is merged
<link rel="preconnect" href="https://fonts.googleapis.com"> | ||
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
<link href="https://fonts.googleapis.com/css2?family=Bangers&display=swap" rel="stylesheet"> | ||
<link rel="stylesheet" type="text/css" href="style.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect css file sheet ref to anticipate
- the file should be named as
styles.css
and notstyle.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect css file
- the file should be named as
styles.css
and notstyle.css
🙏 Thanks for your pull request @Steveo1975, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.
While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!
What I did
Optional: Edit this to tell us what you did!
Pull request checklist
meta.json
file.<github_username>-<art_name>
without the <>.index.html
andstyles.css
.index.html
styles.css
meta.json
with:githubHandle
: being your unique github user name,artName
: name of your animationNot normally needed
Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section
What to expect