[DRAFT] V1 => V2 Contract Upgrade #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell as upgrade flow
Whytecrowe
reviewed
Sep 16, 2025
Whytecrowe
reviewed
Sep 16, 2025
Whytecrowe
reviewed
Sep 16, 2025
Whytecrowe
reviewed
Sep 16, 2025
Whytecrowe
reviewed
Sep 18, 2025
JamesEarle
changed the title
…n_legacy into feat/token-upgrade
Whytecrowe
reviewed
Sep 22, 2025
scripts/upgrade/upgrade-test.ts
Outdated
| @@ -0,0 +1,70 @@ | |||
| import * as hre from "hardhat"; | |||
There was a problem hiding this comment.
we need this to be a proper production ready script
There was a problem hiding this comment.
flows should be separated or withdraw flow removed, since we will use a Safe for the call.
We need at least one script that just does the upgrade and validation on any network.
JamesEarle
force-pushed
the
feat/token-upgrade
branch
2 times, most recently
from
81dce9b to
f0c7ade
Compare
JamesEarle
force-pushed
the
feat/token-upgrade
branch
from
f0c7ade to
18f6387
Compare
…and make a new test for full flow in upgrade
…oc. Also split and improve testing for full flow
State validation for V2 Upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to withdraw ERC20 token that is on the contract