Skip to content

[v1.5 Migration - REVIEW] Registration Locks for migration period [WIP] #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: rc/zns-meowchain
Choose a base branch
from
Draft

[v1.5 Migration - REVIEW] Registration Locks for migration period [WIP] #111

wants to merge 9 commits into from

Conversation

@Whytecrowe
Copy link
Collaborator

@Whytecrowe Whytecrowe commented Jul 9, 2024 •
edited
Loading

Try to find non-upgrade solution before going with this!

TODO:

  1. ZNSSubRegistrar.registerSubdomain() needs to be locked with onlyAdmin.
  2. Test the SubRegistrar lock and upgrade.
  3. Figure out how to still run all the existing local tests with both Registrars locked, so that CI does not fail.

@openzeppelin-code
Copy link

openzeppelin-code bot commented Jul 9, 2024 •
edited
Loading

[Migration Meowchain] Registration Locks for migration period

Generated at commit: 082014b21e7aee4a7c05f3932e8151455f3e8b7b

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 1
1
0
2
20
24
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@Whytecrowe Whytecrowe changed the base branch from development to rc/zns-meowchain July 9, 2024 20:07
@Whytecrowe Whytecrowe changed the title Meowchain migration period Locks [Migration Meowchain] Registration Locks for migration period Jul 17, 2024
@Whytecrowe Whytecrowe changed the title [Migration Meowchain] Registration Locks for migration period [WIP] [Migration Meowchain] Registration Locks for migration period Jul 18, 2024
@Whytecrowe Whytecrowe changed the title [WIP] [Migration Meowchain] Registration Locks for migration period [WIP] [Migration ZChain] Registration Locks for migration period Sep 11, 2024
@Whytecrowe Whytecrowe closed this Dec 17, 2024
@Whytecrowe Whytecrowe changed the title [WIP] [Migration ZChain] Registration Locks for migration period [v1.5 Migration - REVIEW] Registration Locks for migration period [WIP] Feb 25, 2025
@Whytecrowe Whytecrowe reopened this Feb 25, 2025
@Whytecrowe Whytecrowe marked this pull request as draft May 19, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Whytecrowe