drivers: eth_nxp_enet: Fix power mode control #97753
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver should not take the whole interface down and re-initialize on every low power entry and exit. This is a lot of latency for no real gain as far as I can tell. We can just do as the reference manual actually says which is to set the sleep enable bit to put the module to sleep while still being able to detect magic packets for wake on LAN. Also, the only platform that this power action was "enabled" for was kinetis, but that platform does not have any power management enabled in Zephyr. Which means this code was never getting called even with all the PM configs on. So basically this code is dead code. But it could be useful for other platform, such as RT, so there's no reason not to remove the dependency on kinetis and let it be used for any of the platform as long as PM_DEVICE is enabled (hence the imply). Signed-off-by: Declan Snyder <[email protected]>
zephyrbot
requested review from
ClaCodes,
dbaluta,
dleach02,
lmajewski,
maass-hamburg,
manuargue,
mmahadevan108 and
pdgendt
|
dleach02
approved these changes
Oct 17, 2025
pdgendt
approved these changes
Oct 17, 2025
iuliana-prodan
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver should not take the whole interface down and re-initialize on every low power entry and exit. This is a lot of latency for no real gain as far as I can tell. We can just do as the reference manual actually says which is to set the sleep enable bit to put the module to sleep while still being able to detect magic packets for wake on LAN.
Also, the only platform that this power action was "enabled" for was kinetis, but that platform does not have any power management enabled in Zephyr. Which means this code was never getting called even with all the PM configs on. So basically this code is dead code. But it could be useful for other platform, such as RT, so there's no reason not to remove the dependency on kinetis and let it be used for any of the platform as long as PM_DEVICE is enabled (hence the imply).
Resolves #69284