-
Notifications
You must be signed in to change notification settings - Fork 8.1k
stm32: tests: drivers: flash common: align flash size and partition layout #97732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Increase the size of the storage partition by two pages because test_flash_copy needs 2 flash page. Besides, delete obsolete scratch partition and reorder partitions with appropriately Signed-off-by: Fabrice DJIATSA <[email protected]>
update CONFIG_TEST_DRIVER_FLASH_SIZE to match actual flash size. The test was previously failing due to a mismatch between the expected flash size (827392 bytes) and the actual size reported by flash_get_size() (1048576 bytes). This update sets CONFIG_TEST_DRIVER_FLASH_SIZE to 1048576 to reflect the correct size of the flash device as defined in the reference manual for the NUCLEO_WB55RG board. The increase in required flash size (216K) for the full stack M0 binary also justifies aligning the test configuration with the actual hardware capabilities. This change ensures the test passes and accurately reflects the flash memory layout. Signed-off-by: Fabrice DJIATSA <[email protected]>
|
Assigning to @erwango , STM stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For commit ""For commit "boards: st: nucleo_h753zi: update and reorder flash partitions":
Moving slot0/slot1 partitions location do break update compatibility versus prior versions (LTS?). Ditto regarding the scratch partition if previous LTS mcuboot for this board used it.
At least a word or 2 in the migration guide is needed.
Maybe should we add a board variant DTS that provides this compatibility.
Why don't we use the full 2MB available in internal flash?
I understand your suggestion about backward compatibility; I think a solution within the scope of this PR would be to keep the scratch partition and simply move the offsets of the other partitions. A discussion could be held on what strategy to adopt to standardize flash partition layouts in line with migration requirements. |
This PR includes two related updates to improve flash testing and partition layout consistency
NUCLEO_WB55RG
and ensure flash tests pass.
NUCLEO_H753ZI
to support test_flash_copy.