drivers: usb: udc: stm32: fixes around control endpoint/transfers #97729
+96
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop all existing transfers in control endpoints' queue when a new SETUP packet is received. Also use the appropriate net_buf API in a nearby place. Signed-off-by: Mathieu Choplain <[email protected]>
During a Host-to-Device Control transfer, an arbitrary amount of data is sent from Host to the Device using OUT Data packets. If the total amount of data to transfer, communicated via the wLength field of the SETUP packet, exceeds the EP0 MaxPacketSize, several Data packets until all data has been transfered. Combined with HAL behavior, the STM32 driver did not handle this situation properly and always ended reception after a single Data packet was received regardless of whether or not all data had actually been received from Host. Modify driver to handle this situation properly by keeping track of how much data has been received and restarting transfers until we have received everything the Host promised it would send. Signed-off-by: Mathieu Choplain <[email protected]>
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
jfischer-no,
marwaiehm-st and
tmon-nordic
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is similar to what was introduced by #94001 - in my testing, it doesn't seem necessary, but I've included it in this patchset regardless. (I allowed myself to "cherry-pick" it as @nandojve seems unavailable)
Second commit fixes the same issue as #94001 but in a different manner that is, I believe, more solid.
Full testing TBD, but preliminary results show I have same
testusbresults as with #94001.