-
Notifications
You must be signed in to change notification settings - Fork 8.2k
[RFC] doc: develop: manifests: external: add arduino core #97726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| .. code-block:: bash | ||
|
|
||
| git clone https://github.com/arduino/ArduinoCore-API # Any location | ||
| ln -s /<your>/<location>/ArduinoCore-API/api cores/arduino/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the destination is assuming folks are in the module's folder, which is very unlikely the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just make the arduino core api repo an optional west project? Or maybe make both arduino core api and arduino zephyr project part of a group (disabled by default).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah no, this would not be added to the main Zephyr repo. But having the Arduino API as a zephyr module to simplify it's provisioning in people's workspace is a good idea for sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having the Arduino API as a zephyr module to simplify it's provisioning in people's workspace is a good idea for sure
@kartben @Ayush1325 sorry I am not following this conversation too well, What's the conclusion on this one?
Should I add the arduino core zephyr to zephyr/west.yml ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my suggestion was to contribute a zephyr/module.yml to https://github.com/arduino/ArduinoCore-API so that it could then be pulled as a module alongside "arduino-core-zephyr" ; this way simplifying the experience for folks who would not have to git clone and crerate symbolic links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my suggestion was to contribute a zephyr/module.yml to https://github.com/arduino/ArduinoCore-API so that it could then be pulled as a module alongside "arduino-core-zephyr" ; this way simplifying the experience for folks who would not have to git clone and crerate symbolic links?
What do you mean by pulled alongside arduion-core-zephyr?
Even if the ArduinoCore-API is a zephyr module, do we add it to the normal zephyr west.yaml? Or do we expect users to add the module manually to west.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or do we expect users to add the module manually to west.yaml?
yes, it's the whole point of this PR to document how users can add arduinocore-zephyr manually to their workspace, similar to all the others external modules documented hee https://docs.zephyrproject.org/latest/develop/manifest/index.html#external-projects-modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I missed that it will be an external module. Then it makes sense.
4d9735b to
81d384c
Compare
81d384c to
e43b494
Compare
Add documentation for the Arduino Core API for zephyr which sits as an external module as of today. Signed-off-by: Dhruva Gole <[email protected]>
e43b494 to
09b3789
Compare
|



Add documentation for the Arduino Core API for zephyr which sits as an external module as of today.