boards: opta: external flash and BLE support #90264

fogzot · 2025-05-21T09:09:09Z

This set of changes adds support for QSPI-based external flash and Bluetooth to the device tree. This make it possible to correctly build and execute the fatfs and several Bluetooth samples out of the box.

Also added a function to read the external flash OTP to extract information about the Opta model and hardware features and a second function to retrieve the "official" Opta serial number.

pillo79

Thanks for this! There was actually another PR adding initial Flash support to Opta so I waited for that to get in before reviewing this one.
Please rebase and fix the conflicts, mostly LGTM except for the security read operation - to be accepted it should be reworked so it is implemented by the Flash driver.

boards/arduino/opta/doc/index.rst

boards/arduino/opta/board_info.c

boards/arduino/opta/arduino_opta-common.dtsi

boards/arduino/opta/board_info.c

fogzot · 2025-05-26T15:22:44Z

Thanks for this! There was actually another PR adding initial Flash support to Opta so I waited for that to get in before reviewing this one.
Please rebase and fix the conflicts, mostly LGTM except for the security read operation - to be accepted it should be reworked so it is implemented by the Flash driver.

I see some small differences between the current quadspi definition and mine:

bus width is set to 2 but the ST quadspi supports 4 without problems;
maximum frequency is 70 MHz while the datasheet specifies 80 MHz.

It is OK to keep my values or there is indication that Zephyr needs the current values?

pillo79

I see some small differences between the current quadspi definition and mine:

bus width is set to 2 but the ST quadspi supports 4 without problems;

maximum frequency is 70 MHz while the datasheet specifies 80 MHz.

It is OK to keep my values or there is indication that Zephyr needs the current values?

Yes, please use your values - Opta should have no issues supporting 4 lanes and 80MHz clocks.

boards/arduino/opta/board_info.c

Some external flash modules have extra commands to support, for example, reading/writing an OTP zone. Given that the commands are highly specific and difficult to generalize, we add two ex ops that can be used to transmit a custom command (in the form of a full QSPI_CommandTypeDef) and then read or write a user-provided buffer. As a reference here is the link to the discussion where one of the reviewers asked for using ex ops instead of custom code in a board.c file. Link: zephyrproject-rtos#90264 Signed-off-by: Federico Di Gregorio <[email protected]>

fogzot · 2025-06-20T14:37:10Z

I think the last push addresses al open issues.

etienne-lms

Some minor comments, otherwise LGTM.

boards/arduino/opta/arduino_opta-external-flash-partitioning.dtsi

boards/arduino/opta/arduino_opta_stm32h747xx_m7.dts

boards/arduino/opta/board.h

etienne-lms · 2025-06-23T11:04:44Z

boards/arduino/opta/board_info.c

+#define AT25SF128_READ_SECURITY_REGISTERS 0x48
+
+static struct opta_board_info opta_board_info = {0};
+static char serial_number[OPTA_SERIAL_NUMBER_SIZE + 1] = {0};


{0} initializer is not needed in the 2 lines above.

This was fact actually useful for the serial number, since the very first call to opta_get_serial_number is expecting to find a zero-filled buffer (and return a zero-terminated string):

zephyr/boards/arduino/opta/board_info.c

Lines 78 to 83 in 51bde72

if (serial_number[0] == 0) {

uint32tohex(&serial_number[0], HAL_GetUIDw0());

uint32tohex(&serial_number[8], HAL_GetUIDw1());

uint32tohex(&serial_number[16], HAL_GetUIDw2());

}

return serial_number;

Please restore this to ensure proper operation, otherwise LGTM!

Reading @etienne-lms comment I tought that statics where automatically zeroed. If they are not then the initialization is necessary. I'll revert the change.

They should be unless I missed something. Static variables are expected to fall in the BSS section if not initialized, and in the data section if initialized.

Yep, my bad, forgot that actually are zero initialized already. Sorry for the misdirection! 🤦‍♂️

fogzot · 2025-06-25T07:32:35Z

@etienne-lms I just pushed all requested changes.

etienne-lms

LGTM with comment addressed or not.

etienne-lms · 2025-06-25T08:42:33Z

boards/arduino/opta/board_info.c

+	int ret = flash_ex_op(dev, FLASH_STM32_QSPI_EX_OP_GENERIC_READ, (uintptr_t)&cmd,
+			      &opta_board_info);


Nitpicking suggestion:

return flash_ex_op(dev, FLASH_STM32_QSPI_EX_OP_GENERIC_READ, (uintptr_t)&cmd, &opta_board_info);

boards/arduino/opta/arduino_opta-external-flash-partitioning.dtsi

boards/arduino/opta/board_info.c

samples/subsys/fs/fs_sample/boards/arduino_opta_stm32h747xx_m7.conf

GeorgeCGV · 2025-06-26T18:24:57Z

boards/arduino/opta/arduino_opta_stm32h747xx_m7.dts

+	qspi_flash: qspi-nor-flash@90000000 {
 		compatible = "st,stm32-qspi-nor";
-		reg = <0>;
+		reg = <0x90000000 DT_SIZE_M(16)>;


Needs to account for #89942

I see. I was not aware of the change so I just use the definition I knew worked. I just fixed this.

This set of changes adds support for QSPI-based external flash and Bluetooth to the device tree. This make it possible to correctly build and execute the fatfs and several Bluetooth samples out of the box. Also added a function to read the external flash OTP to extract information about the Opta model and hardware features and a second function to retrieve the "official" Opta serial number. Signed-off-by: Federico Di Gregorio <[email protected]>

sonarqubecloud · 2025-06-27T11:06:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions bot added area: Samples Samples area: File System labels May 21, 2025

github-actions bot requested review from de-nordic, facchinm, kartben, Laczen, nashif and pillo79 May 21, 2025 09:10

github-actions bot assigned de-nordic May 21, 2025

fogzot force-pushed the opta branch 2 times, most recently from 28519eb to 79db4d0 Compare May 21, 2025 10:19

pillo79 mentioned this pull request May 23, 2025

boards: opta: enable qspi #89539

Merged

pillo79 requested changes May 23, 2025

View reviewed changes

boards/arduino/opta/doc/index.rst Outdated Show resolved Hide resolved

boards/arduino/opta/board_info.c Outdated Show resolved Hide resolved

boards/arduino/opta/arduino_opta-common.dtsi Outdated Show resolved Hide resolved

boards/arduino/opta/board_info.c Outdated Show resolved Hide resolved

pillo79 self-assigned this May 23, 2025

pillo79 reviewed May 27, 2025

View reviewed changes

boards/arduino/opta/board_info.c Outdated Show resolved Hide resolved

de-nordic removed their assignment Jun 3, 2025

fogzot mentioned this pull request Jun 6, 2025

drivers: flash: stm32: add "generic read/write" ex op to QSPI driver #91186

Merged

fogzot force-pushed the opta branch from 79db4d0 to 0a27b5a Compare June 6, 2025 16:39

github-actions bot added area: Flash platform: STM32 ST Micro STM32 labels Jun 6, 2025

github-actions bot requested review from djiatsaf-st, erwango, etienne-lms, FRASTM, gautierg-st, GeorgeCGV and marwaiehm-st June 6, 2025 16:40

fogzot force-pushed the opta branch from fe6579b to c6302b5 Compare June 20, 2025 12:08

fogzot requested a review from pillo79 June 20, 2025 14:37

pillo79 previously approved these changes Jun 20, 2025

View reviewed changes

etienne-lms reviewed Jun 23, 2025

View reviewed changes

fogzot dismissed pillo79’s stale review via 967a07a June 25, 2025 07:32

fogzot force-pushed the opta branch from c6302b5 to 967a07a Compare June 25, 2025 07:32

fogzot force-pushed the opta branch from 967a07a to c3e6724 Compare June 25, 2025 08:33

etienne-lms previously approved these changes Jun 25, 2025

View reviewed changes

fogzot dismissed etienne-lms’s stale review via 6c3d353 June 25, 2025 10:10

fogzot force-pushed the opta branch 2 times, most recently from 6c3d353 to 4557ab6 Compare June 25, 2025 11:38

fogzot requested review from etienne-lms and pillo79 June 25, 2025 16:33

GeorgeCGV reviewed Jun 25, 2025

View reviewed changes

boards/arduino/opta/arduino_opta-external-flash-partitioning.dtsi Show resolved Hide resolved

GeorgeCGV reviewed Jun 25, 2025

View reviewed changes

boards/arduino/opta/board_info.c Outdated Show resolved Hide resolved

GeorgeCGV reviewed Jun 25, 2025

View reviewed changes

boards/arduino/opta/board_info.c Show resolved Hide resolved

GeorgeCGV reviewed Jun 25, 2025

View reviewed changes

samples/subsys/fs/fs_sample/boards/arduino_opta_stm32h747xx_m7.conf Outdated Show resolved Hide resolved

fogzot force-pushed the opta branch from 4557ab6 to a5bc658 Compare June 26, 2025 16:09

GeorgeCGV reviewed Jun 26, 2025

View reviewed changes

fogzot force-pushed the opta branch 2 times, most recently from 51bde72 to 74ecb86 Compare June 27, 2025 10:28

fogzot force-pushed the opta branch from 74ecb86 to 12ed358 Compare June 27, 2025 10:40

pillo79 approved these changes Jun 27, 2025

View reviewed changes

marekmatej approved these changes Jun 27, 2025

View reviewed changes

etienne-lms approved these changes Jun 27, 2025

View reviewed changes

danieldegrasse merged commit 2221072 into zephyrproject-rtos:main Jun 27, 2025
20 checks passed

	if (serial_number[0] == 0) {
	uint32tohex(&serial_number[0], HAL_GetUIDw0());
	uint32tohex(&serial_number[8], HAL_GetUIDw1());
	uint32tohex(&serial_number[16], HAL_GetUIDw2());
	}
	return serial_number;

		int ret = flash_ex_op(dev, FLASH_STM32_QSPI_EX_OP_GENERIC_READ, (uintptr_t)&cmd,
		&opta_board_info);

boards: opta: external flash and BLE support #90264

boards: opta: external flash and BLE support #90264

Uh oh!

Conversation

fogzot commented May 21, 2025

Uh oh!

pillo79 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fogzot commented May 26, 2025

Uh oh!

pillo79 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fogzot commented Jun 20, 2025

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fogzot commented Jun 25, 2025

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jun 27, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!