app: Use fallback command if extension command could not load #894
+282
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
==========================================
+ Coverage 85.04% 85.95% +0.90%
==========================================
Files 11 11
Lines 3451 3452 +1
==========================================
+ Hits 2935 2967 +32
+ Misses 516 485 -31
|
carlescufi
approved these changes
Dec 10, 2025
The west extension factory is not guaranteed to succesfully set self.cmd in the WestApp instance. For example if a module could not be loaded. Use the builtin Help command as a fallback. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
handle-extension-error
branch
from
4ae3803 to
c9895b3
Compare
Add a file with tests for validating West extension command handling. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
handle-extension-error
branch
from
c9895b3 to
c00fb56
Compare
thorsten-klein
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The west extension factory is not guaranteed to succesfully set self.cmd in the WestApp instance. For example if a module could not be loaded.
Use the builtin Help command as a fallback.
Fixes #893