gdb: Default to _WIN32_WINNT=0x0600 #969
Merged
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
added
area: GDB
|
DNM until zephyrproject-rtos/binutils-gdb#18 is merged. |
stephanosio
force-pushed
the
topic-sdk-build-mingw-gdb
branch
2 times, most recently
from
ba9ae3b to
42bacb6
Compare
|
In conjunction with #974, verified that the GDB executable builds successfully and runs on Windows with no direct MinGW dependencies; also note that it links against the UCRT ( 
|
|
Reverting "workaround for issue wih gdb/mingw" and making GCC build with the sdk-build MinGW toolchain seems to have made GCC misbehave for some Xtensa targets, which is a separate issue from what this PR fixes: Full log: https://github.com/zephyrproject-rtos/sdk-ng/actions/runs/16438257464/job/46465635676 This is likely a file path length issue given that it only happens with the Xtensa toolchains with longer paths ... UPDATE It is indeed a long path issue. The issue is locally reproducible on a Windows 10 22H2 machine; moving the toolchain directory to a shorter path makes the compilation succeed. Based on https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry, enabling system-wide long path support ( |
This commit pulls in the GDB patch that sets `_WIN32_WINNT` to 0x0600 when not explicitly defined in the CFLAGS. Note that, libstdc++, when building with the win32 thread model, only supports std::mutex and std:condition_variable if _WIN32_WINNT >= 0x0600. Signed-off-by: Stephanos Ioannidis <[email protected]>
This reverts commit 5423f49 because the GDB build issue has been fixed. Signed-off-by: Stephanos Ioannidis <[email protected]>
|
Re: #969 (comment) Created a separate issue tracking this: #979 This will be fixed in a separate follow-up PR. |
stephanosio
force-pushed
the
topic-sdk-build-mingw-gdb
branch
from
42bacb6 to
93c46c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pulls in the GDB patch that sets
_WIN32_WINNTto 0x0600when not explicitly defined in the CFLAGS.
Note that, libstdc++, when building with the win32 thread model, only
supports std::mutex and std:condition_variable if _WIN32_WINNT >=
0x0600.
GDB PR: zephyrproject-rtos/binutils-gdb#18
Tested in https://github.com/zephyrproject-rtos/sdk-ng/actions/runs/16438257464
Fixes #964