Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNSA presets #62

Open
wants to merge 1 commit into
base: zephyr
Choose a base branch
from

Conversation

krish2718
Copy link

CNSA supersedes NSA SuiteB crypto suites, esp. brings back RSA with higher modulus (>=3072). This was based on RFC9151, see [1].

Implements #4602.

[1] - https://datatracker.ietf.org/doc/rfc9151/

Upstream PR: Mbed-TLS/mbedtls#9460

Description

Please write a few sentences describing the overall goals of the pull request's commits.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog provided, or not required
  • 3.6 backport done, or not required
  • 2.28 backport done, or not required
  • tests provided, or not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

CNSA supersedes NSA SuiteB crypto suites, esp. brings back RSA with
higher modulus (>=3072). This was based on RFC9151, see [1].

Implements #4602.

[1] - https://datatracker.ietf.org/doc/rfc9151/

Upstream PR: Mbed-TLS/mbedtls#9460

Signed-off-by: Chaitanya Tata <[email protected]>
Copy link
Collaborator

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather have you address the comments you have received on your upstream PR. We always strive to do upstream first, and in this repo only apply cherry picks or patches incompatible with upstream.
By the way you can clean up the PR description, the template happens to be inherited by the upstream Mbed TLS repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants