Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RouteVoter #4

Merged
merged 2 commits into from
May 14, 2023
Merged

Adding RouteVoter #4

merged 2 commits into from
May 14, 2023

Conversation

msmakouz
Copy link
Contributor

Q A
Branch?
Bug fix?
Breaks BC?
New feature? ✔️
Deprecations?

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023

Codecov Report

Merging #4 (03d4bb1) into master (fc26503) will increase coverage by 11.01%.
The diff coverage is 91.17%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff              @@
##             master       #4       +/-   ##
=============================================
+ Coverage     68.33%   79.34%   +11.01%     
- Complexity       28       39       +11     
=============================================
  Files             5        6        +1     
  Lines            60       92       +32     
=============================================
+ Hits             41       73       +32     
  Misses           19       19               
Impacted Files Coverage Δ
src/Extension/RoutingExtension.php 11.11% <0.00%> (+11.11%) ⬆️
src/Bootloader/KnpMenuBootloader.php 95.23% <93.33%> (+5.58%) ⬆️
src/Config/KnpMenuConfig.php 100.00% <100.00%> (ø)
src/Matcher/Voter/RouteVoter.php 100.00% <100.00%> (ø)

@msmakouz msmakouz merged commit a3244b8 into master May 14, 2023
5 checks passed
@msmakouz msmakouz deleted the feature/voters branch May 14, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants