[minor] support Symfony 6.1 (#63)

zenstruck · Apr 16, 2022 · 191e113 · 191e113
1 parent 7c8a225
commit 191e113
Show file tree

Hide file tree

Showing 8 changed files with 45 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,6 +25,9 @@ jobs:
           - php: 8.1
             deps: hightest
             symfony: 6.0.*
+          - php: 8.1
+            deps: hightest
+            symfony: 6.1.*
     steps:
       - uses: zenstruck/.github@php-test-symfony
         with:

diff --git a/src/Command/ScheduleListCommand.php b/src/Command/ScheduleListCommand.php
@@ -20,8 +20,6 @@
  */
 final class ScheduleListCommand extends Command
 {
-    protected static $defaultName = 'schedule:list';
-
     /** @var ScheduleRunner */
     private $scheduleRunner;
 
@@ -36,10 +34,20 @@ public function __construct(ScheduleRunner $scheduleRunner, ExtensionHandlerRegi
         parent::__construct();
     }
 
+    public static function getDefaultName(): string
+    {
+        return 'schedule:list';
+    }
+
+    public static function getDefaultDescription(): string
+    {
+        return 'List configured scheduled tasks';
+    }
+
     protected function configure(): void
     {
         $this
-            ->setDescription('List configured scheduled tasks')
+            ->setDescription(self::getDefaultDescription()) // required for Symfony 4.4
             ->addOption('detail', null, null, 'Show detailed task list')
             ->setHelp(<<<EOF
 Exit code 0: no issues.

diff --git a/src/Command/ScheduleRunCommand.php b/src/Command/ScheduleRunCommand.php
@@ -16,8 +16,6 @@
  */
 final class ScheduleRunCommand extends Command
 {
-    protected static $defaultName = 'schedule:run';
-
     /** @var ScheduleRunner */
     private $scheduleRunner;
 
@@ -32,10 +30,20 @@ public function __construct(ScheduleRunner $scheduleRunner, EventDispatcherInter
         parent::__construct();
     }
 
+    public static function getDefaultName(): string
+    {
+        return 'schedule:run';
+    }
+
+    public static function getDefaultDescription(): string
+    {
+        return 'Runs scheduled tasks that are due';
+    }
+
     protected function configure(): void
     {
         $this
-            ->setDescription('Runs scheduled tasks that are due')
+            ->setDescription(self::getDefaultDescription()) // required for Symfony 4.4
             ->addArgument('id', InputArgument::IS_ARRAY | InputArgument::OPTIONAL, '(optional) Task ID\'s to "force" run')
             ->setHelp(<<<EOF
 If no arguments are passed, all the tasks currently due are run. Pass one or

diff --git a/tests/Command/ScheduleListCommandTest.php b/tests/Command/ScheduleListCommandTest.php
@@ -178,7 +178,10 @@ public function command_task_with_invalid_argument_shows_as_error()
 
         $application = new Application();
         $application->add(new class() extends Command {
-            protected static $defaultName = 'my:command';
+            public static function getDefaultName(): string
+            {
+                return 'my:command';
+            }
 
             protected function configure()
             {

diff --git a/tests/Fixture/ScheduledCommand.php b/tests/Fixture/ScheduledCommand.php
@@ -13,5 +13,8 @@
 #[AsScheduledTask('@monthly', arguments: '-vv --no-interaction')]
 final class ScheduledCommand extends Command
 {
-    protected static $defaultName = 'my:command';
+    public static function getDefaultName(): string
+    {
+        return 'my:command';
+    }
 }
diff --git a/tests/Schedule/SelfSchedulingCommandTest.php b/tests/Schedule/SelfSchedulingCommandTest.php
@@ -20,7 +20,10 @@ final class SelfSchedulingCommandTest extends TestCase
     public function commands_can_self_schedule()
     {
         $command = new class() extends Command implements SelfSchedulingCommand {
-            protected static $defaultName = 'my:command';
+            public static function getDefaultName(): string
+            {
+                return 'my:command';
+            }
 
             public function schedule(CommandTask $task): void
             {

diff --git a/tests/Schedule/Task/CommandTaskTest.php b/tests/Schedule/Task/CommandTaskTest.php
@@ -98,5 +98,8 @@ public function unregistered_command_throws_exception()
 
 final class DummyCommand extends Command
 {
-    protected static $defaultName = 'dummy:command';
+    public static function getDefaultName(): string
+    {
+        return 'dummy:command';
+    }
 }
diff --git a/tests/Schedule/Task/Runner/CommandTaskRunnerTest.php b/tests/Schedule/Task/Runner/CommandTaskRunnerTest.php
@@ -101,7 +101,10 @@ public function supports_command_task()
     private function createCommand(): Command
     {
         return new class() extends Command {
-            protected static $defaultName = 'my:command';
+            public static function getDefaultName(): string
+            {
+                return 'my:command';
+            }
 
             protected function configure()
             {