-
-
Notifications
You must be signed in to change notification settings - Fork 38
doc: field-level policy #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR documents field-level access control policies in ORM documentation, including usage examples with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/orm/access-control/field-level.md (2)
34-34: Fix subject-verb agreement in sentence.Line 34 contains a grammatical error: "fields that violates" should be "fields that violate."
Suggested fix
-When reading a row, fields that violates "read" policies will be nullified in the result. Conceptually, the following form of SQL is generated to guard the fields: +When reading a row, fields that violate "read" policies will be nullified in the result. Conceptually, the following form of SQL is generated to guard the fields:
48-48: Improve clarity of phrasing in the caveat explanation.Line 48 reads awkwardly: "Setting unreadable fields null" lacks a preposition. Consider: "Setting unreadable fields to null."
Suggested fix
-Setting unreadable fields null brings a caveat that you cannot tell whether a field is actually `NULL` in the database or just unreadable due to access control. So why don't we instead omit the fields from the result? +Setting unreadable fields to null brings a caveat that you cannot tell whether a field is actually `NULL` in the database or just unreadable due to access control. So why don't we instead omit the fields from the result?
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/orm/access-control/field-level.mddocs/roadmap.md
🔇 Additional comments (2)
docs/orm/access-control/field-level.md (1)
5-60: Strong documentation for field-level access control policies.The documentation provides a clear, well-structured introduction to field-level policies. The code example effectively illustrates the feature, and the sections covering constraints, read behavior, update behavior, and caveats comprehensively explain the key concepts. The SQL conceptual representation helps readers understand the underlying mechanism, and the caveat section addresses an important design decision. The roadmap and Samples placeholders set appropriate expectations for readers.
docs/roadmap.md (1)
16-16: Roadmap status update is accurate.The status change for "Field-level access control" from uncompleted to completed aligns with the comprehensive documentation added in the corresponding file.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.