Configure DB read replica and routing #1227
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # | ||
| # Copyright (C) 2025 CERN. | ||
| # | ||
| # ZenodoRDM is free software; you can redistribute it and/or modify it | ||
| # under the terms of the MIT License; see LICENSE file for more details. | ||
| """Database helpers.""" | ||
|
|
||
| from flask import current_app, request | ||
| from flask_login import current_user | ||
|
|
||
|
|
||
| def routed_bind(session, *args, **kwargs): | ||
| """Route session to the appropriate database depending on the request context. | ||
|
|
||
| Routes unauthenticated/anonymous GET and HEAD requests of configured endpoints to | ||
| the configured read replica SQLAlchemy bind. | ||
| """ | ||
| if request and request.method in ["GET", "HEAD"]: | ||
| read_endpoints = current_app.config.get("ZENODO_READ_REPLICA_ENDPOINTS", []) | ||
| if current_user.is_anonymous and request.endpoint in read_endpoints: | ||
| return session._db.engines["read_replica"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need a second look. I removed from the initiali list all the
POST/PUT/DELETEroutes and did a manual pass to make sure none of these routes have hidden DB writes (like e.g. the/confirmroute).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you observing high traffic in all these endpoints? Otherwise you can evaluate adding only a subset of those and then progressively expanding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, but I thought narrowing down all the read endpoints and filtering afterwards will make sure we don't miss anything (like e.g. the legacy redirect endpoints, which are linked to around the web already).