Fix :Add a link to the github project

[Pawankalyan2023]

Fix #22 : Add a link to the github project

Description :

I have added the github logo so as to contribute to our project , attached a reference so that you can get an idea of how it is being placed , please do review and check if it is okay , I have added next to settings modal so that it relates to an icon

[david-dasilva]

Thanks for your contribution!

I would prefer if it was on the bottom of the settings modal to avoid a user pressing the github logo by mistake when they wanted to press the settings button.

I would like to keep the main screen uncluttered as much as possible.

Could you do that? Thanks

[david-dasilva]

please avoid committing settings files

[david-dasilva]

Please use the official svg logo provided here : https://github.com/logos it's a lot smaller than the png version. Don't forget the alt text for a11y :)

[Pawankalyan2023]

Hi @david-dasilva , I have updated the code according to ur needs

[david-dasilva]

Suggested change

	<a href="https://github.com/zenika-open-source/clepsydre">
	<p>Contribute to our project</p>
	<img src="img/github-mark-white.png" alt="Github" />
	</a>
	<a href="https://github.com/zenika-open-source/clepsydre" title="contribute to the project on Github">
	Contribute on Github <img src="img/github-mark-white.png" alt="Github logo" />
	</a>

But you didn't use the svg file, instead you added 3 png to the project.

[Pawankalyan2023]

Changed now

[Pawankalyan2023]

Hi @david-dasilva , do i need to change anything still ?

[david-dasilva]

Hi @Pawankalyan2023, yes you do, as indicated by the pending discussions :

• use svg and not png file
• remove settings.json

To which I would add :

• Please make sure your pull request only change lines of code relevant to the feature your are trying to implement: avoid adding empty lines or changing the indentation on unrelated lines for example.
• Avoid using absolute px unit as it breaks responsive design.
• I see css rules that are useless : for example there is no <p> in your github div, so the rule #github p can be removed. Same with your #settingsModal .buttons rule that does something already existing. There might be more.
• Since the project has evolved, your branch now have conflicts, you should rebase and resolve conflicts.

Please let me know if you have questions.