Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Allow services from container #310

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

thomasvargiu
Copy link

Allow retrieving services from container in ModuleManagerFactory

@thomasvargiu thomasvargiu changed the base branch from master to develop February 17, 2019 14:33
@thomasvargiu
Copy link
Author

thomasvargiu commented Mar 19, 2019

@weierophinney can you re-run the failed test?
With this PR I will able to use the same configured container from a zend-expressive configuration in a zend-mvc application, disabling the ServiceListener::addServiceManager() calls (and some other changes).

It could be nice if we can cherry-pick on master for the next release.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-mvc; a new issue has been opened at laminas/laminas-mvc#7.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-mvc. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mvc to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mvc.
  • In your clone of laminas/laminas-mvc, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants