This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Added IbmDb2 db2_pclose to disconnect #333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the disconnect method to choose db2_pclose or db2_close based on the resource's connectionParameter for persistence.
Ocramius
suggested changes
Aug 9, 2018
| $p = $this->connectionParameters; | ||
|
|
||
| // given a list of key names, test for existence in $p | ||
| $findParameterValue = function (array $names) use ($p) { |
There was a problem hiding this comment.
Make a new private method returning bool instead. Also, array_change_key_case() is probably a better approach, since nothing guarantees that mIxEDCasE won't be given as parameter.
|
Was this supposed to be closed? |
|
Sorry, I'm new at GitHub and thought the pull request was rejected and I needed to create a new one. |
|
Hah, ok. You can just send more commits to this branch, and that will
update the patch.
…On Tue, 14 Aug 2018, 17:47 JargonMan, ***@***.***> wrote:
Sorry, I'm new at GitHub and thought the pull request was rejected and I
needed to create a new one.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#333 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakN7hVApH9aE6PaCiLIkrff2QN3Idks5uQvEkgaJpZM4V0pXQ>
.
|
|
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#27. |
|
This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the disconnect method to choose db2_pclose or db2_close based on the resource's connectionParameter for persistence.
The public function connect() creates either persistent or non persistent db2 connections based on a connection parameter.
This update uses the same logic in the public function disconnect() to close the connection. Previously persistent connections would not have been closed with the db2_close() call, because they need the db2_pclose() call.