ViewHelperProviderInterface #3
Conversation
There was a problem hiding this comment.
@boesing Thanks for the PR! In general looks good, just not sure if it should be Feature or Hotfix. Please see my other small comments.
|
|
||
| ### Added | ||
|
|
||
| - Nothing. | ||
| - [#3](https://github.com/zendframework/zend-config-aggregator-modulemanager/pull/3) adds support for `ViewHelperProviderInterface` |
There was a problem hiding this comment.
I am not sure if it should be considered as "new feature" or a bugfix.
Also description should be a bit extended, to describe what is the fix/feature.
There was a problem hiding this comment.
Actually it is a "new feature" as the view_helpers array key didnt exist in the first place.
It would be a bug if we say "we are handling every method in your module" but actually we just had the features provided by the current ConfigProvider.
I am not sure if its a bugfix as the package never said that it can parse the view_helpers config at all.
| @@ -177,7 +179,7 @@ public function getHydratorConfig() : array | |||
| return $this->convert($this->module->getHydratorConfig()); | |||
| } | |||
|
|
|||
| public function getInputFilterConfig() | |||
| public function getInputFilterConfig() /* : array */ | |||
There was a problem hiding this comment.
does it help with anything now? Or it is just added because it was missed in that place as 'hard' RTH?
There was a problem hiding this comment.
I obviously forgot to add this in the first release.
Therefore I thought adding that comment to remind me that I have to add it in the next major release (as its a bc in case of extending the ConfigProvider. Should have put a final on it since it should be never extended at all...)
|
This repository has been closed and moved to laminas/laminas-config-aggregator-modulemanager; a new issue has been opened at laminas/laminas-config-aggregator-modulemanager#1. |
|
This repository has been moved to laminas/laminas-config-aggregator-modulemanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
I forgot to implement the
ViewHelperProviderInterfacein the initial release.