Merge pull request #416 from ins0/fix/415

Hotfix: Added correct type comparison
zendframework · Feb 24, 2015 · 8c55276 · 8c55276
2 parents 3b7b277 + b9fde45
commit 8c55276
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/module/ZfModule/src/ZfModule/Service/Module.php b/module/ZfModule/src/ZfModule/Service/Module.php
@@ -131,7 +131,7 @@ public function currentUserModules()
                 return false;
             }
 
-            if (null === $this->moduleMapper->findByUrl($repository->html_url)) {
+            if (false === $this->moduleMapper->findByUrl($repository->html_url)) {
                 return false;
             }
 

diff --git a/module/ZfModule/test/ZfModuleTest/Service/ModuleTest.php b/module/ZfModule/test/ZfModuleTest/Service/ModuleTest.php
@@ -221,7 +221,7 @@ public function testListUserModulesDoesNotListModulesFromApiNotFoundInDatabase()
             ->expects($this->once())
             ->method('findByUrl')
             ->with($this->equalTo($repository->html_url))
-            ->willReturn(null)
+            ->willReturn(false)
         ;
 
         $currentUserService = $this->getMockBuilder(Api\CurrentUser::class)->getMock();
@@ -381,7 +381,7 @@ public function testRegisterInsertsModule()
             ->expects($this->once())
             ->method('findByUrl')
             ->with($this->equalTo($repository->html_url))
-            ->willReturn(null)
+            ->willReturn(false)
         ;
 
         $moduleMapper