Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing translations #522

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix missing translations #522

merged 2 commits into from
Sep 9, 2024

Conversation

Fredx87
Copy link
Contributor

@Fredx87 Fredx87 commented Sep 9, 2024

Description

This PR:

  • Commit the built JS bundles. They include the translation strings that were missing.
  • Fixes a wrong translation key
  • Restores a package in package.json which was removed by mistake

Note: this PR will be merged to the lookup-fields branch and not released yet

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@Fredx87 Fredx87 requested a review from a team as a code owner September 9, 2024 09:56
@Fredx87 Fredx87 merged commit f2f1104 into lookup-fields Sep 9, 2024
5 checks passed
@Fredx87 Fredx87 deleted the gianluca/lookup-fields-l10n-fix branch September 9, 2024 12:03
@zd-svc-github-copenhagen-theme
Copy link
Collaborator

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoBFerreira BrunoBFerreira BrunoBFerreira approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fredx87 @zd-svc-github-copenhagen-theme @BrunoBFerreira