Remove aria-expanded attribute from section tag in search result page #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smansouri
force-pushed
the
smansouri.remove-aria-expanded-from-section
branch
3 times, most recently
from
377a101
to
354fe65
Compare
|
Hi @sergioazevedo, can you please take a look at this PR? 🙏 |
smansouri
force-pushed
the
smansouri.remove-aria-expanded-from-section
branch
from
354fe65
to
88daf87
Compare
sergioazevedo
approved these changes
Jun 26, 2023
|
🎉 This PR is included in version 3.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is reported by accessibility team to remove
aria-expandedfrom section tag. This attribute applies to the button in the sidebar for mobile view and we don't need to have it for section.Jira issue
Checklist