fix(zellij-server): unblock building on 32bit targets #4484
+3
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the migration to
wasmi(#4449), we should be able to build for 32bit targets (wasm runtimes have notoriously had issues with such targets, see https://docs.wasmtime.dev/stability-tiers.html#unsupported-features-and-platforms).While testing with builds on Void Linux for i686, I noticed the static asserts in our code that hardcode support for 64bit platforms only. These were introduced as an optimization (#3043), but I'd argue that this is a bit overly pedantic, especially when it effectively limits possible target platforms for no reason.
Hence, my proposal to drop them altogether as a simple solution. I'm aware that we could instead rewrite those to take platform-specific pointer size into account, but especially in the case of
TerminalCharacterit becomes cumbersome to cleanly express what the expected size should be.When testing I at least made sure that the new reported size only goes down for the affected target.
cc @aidanhs for comments and suggestions