Skip to content

Conversation

@myInstagramAlternative
Copy link

@myInstagramAlternative myInstagramAlternative commented Oct 17, 2025

XTGETTCAP terminal capability query support (DCS sequences with hex-encoded capability names, responses for terminal name, columns, lines, and clipboard support).

Closes #4320, #2637 and #3951

XTGETTCAP terminal capability query support (DCS sequences with
hex-encoded capability names, responses for terminal name, columns,
lines, and clipboard support).
@myInstagramAlternative myInstagramAlternative marked this pull request as ready for review October 17, 2025 19:04
Copilot AI review requested due to automatic review settings October 17, 2025 19:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements XTGETTCAP terminal capability query support, allowing Zellij to respond to DCS (Device Control String) sequences with hex-encoded capability names. The implementation adds support for querying terminal name, columns, lines, and clipboard support capabilities.

Key changes include:

  • Added a new enable_xtgettcap configuration option across the codebase
  • Implemented DCS query parsing and response generation in the Grid implementation
  • Added test coverage for XTGETTCAP queries including terminal name, columns, and clipboard capabilities

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
zellij-utils/src/kdl/mod.rs Added parsing for enable_xtgettcap configuration option from KDL
zellij-utils/src/input/options.rs Added enable_xtgettcap field to Options struct with CLI and merge support
zellij-utils/src/client_server_contract/common_types.proto Added enable_xtgettcap field to protobuf Options message
zellij-utils/assets/prost_ipc/client_server_contract.rs Generated protobuf code for new enable_xtgettcap field
zellij-utils/src/ipc/protobuf_conversion.rs Added protobuf conversion for enable_xtgettcap option
zellij-utils/src/ipc/tests/roundtrip_tests.rs Updated test to include enable_xtgettcap field
zellij-server/src/screen.rs Threaded enable_xtgettcap parameter through Screen initialization
zellij-server/src/tab/mod.rs Threaded enable_xtgettcap parameter through Tab and pane creation
zellij-server/src/tab/layout_applier.rs Threaded enable_xtgettcap parameter through LayoutApplier
zellij-server/src/panes/terminal_pane.rs Added enable_xtgettcap parameter to TerminalPane constructor
zellij-server/src/panes/plugin_pane.rs Added enable_xtgettcap parameter to PluginPane constructor
zellij-server/src/panes/grid.rs Implemented XTGETTCAP and DECRQSS query handling with DCS buffer management
zellij-server/src/panes/unit/grid_tests.rs Added comprehensive tests for XTGETTCAP functionality
Multiple test files Updated test constructors to pass false for enable_xtgettcap parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support XTGETTCAP

1 participant