Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEA-4455: zbpack.json schema #447

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

pan93412
Copy link
Member

@pan93412 pan93412 commented Mar 26, 2025

Description (required)

  • refactor(planner/rust): Use the standard app_dir
  • feat: Add zbpack JSON schema

Related issues & labels (optional)

  • Closes ZEA-4455
  • Suggested label: enhancement

@pan93412 pan93412 self-assigned this Mar 26, 2025
@pan93412 pan93412 requested a review from Copilot March 26, 2025 05:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements a schema update for zbpack JSON and refactors the Rust planner to use a standardized application directory key.

  • Refactors configuration key for application directory (from "rust.app_dir" to "app_dir").
  • Adjusts tests to verify both legacy and new configuration key behavior.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
internal/rust/rust_test.go Updates tests to use the legacy key and verifies new behavior.
internal/rust/plan.go Refactors configuration key definitions and error handling in getAppDir.
Files not reviewed (1)
  • schema/zbpack.json: Language not supported
Comments suppressed due to low confidence (1)

internal/rust/plan.go:30

  • [nitpick] The new key 'app_dir' for ConfigRustAppDir may cause confusion with the legacy key 'rust.app_dir'. Ensure that documentation and configuration migration paths clearly explain this change.
const ConfigRustAppDir = "app_dir"

@pan93412 pan93412 merged commit b830f0f into main Mar 26, 2025
5 checks passed
@pan93412 pan93412 deleted the pan93412/zea-4455-zbpackjson-json-schema branch March 26, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant