Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEA-4468: Supoort new CheckDomainAvailable API in CLI #116

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ZEA-4468: Supoort new CheckDomainAvailable API in CLI #116

wants to merge 2 commits into from

Conversation

pan93412
Copy link
Member

@pan93412 pan93412 commented Jan 14, 2025 •
edited
Loading

Description (required)

  • feat(api)!: Add "AvailableSuffix" field
  • refactor: Use new CheckDomainAvailable API for hinting domain

Related issues & labels (optional)

  • Closes ZEA-4468
  • Suggested label: enhancement

@pan93412 pan93412 self-assigned this Jan 14, 2025
@pan93412 pan93412 added the enhancement New feature or request label Jan 14, 2025
@pan93412 pan93412 requested a review from Copilot January 14, 2025 10:14
Copilot
Copilot AI reviewed Jan 14, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

internal/cmd/template/deploy/deploy.go Show resolved Hide resolved
internal/cmd/template/deploy/deploy.go Show resolved Hide resolved
@pan93412 pan93412 marked this pull request as ready for review January 15, 2025 09:03
@pan93412 pan93412 requested a review from yuaanlin January 15, 2025 09:55
@pan93412 pan93412 marked this pull request as draft January 24, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@yuaanlin yuaanlin Awaiting requested review from yuaanlin

Assignees

@pan93412 pan93412

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pan93412